----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56106/#review163670 -----------------------------------------------------------
Ship it! Ship It! - Kevin Duling On Jan. 30, 2017, 5:15 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56106/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 5:15 p.m.) > > > Review request for geode, Jared Stewart and Kevin Duling. > > > Bugs: GEODE-2395 and GEODE-2396 > https://issues.apache.org/jira/browse/GEODE-2395 > https://issues.apache.org/jira/browse/GEODE-2396 > > > Repository: geode > > > Description > ------- > > GEODE-2395: add FlakyCategory to intermittently failing test > > Remove unnecessary throws clause. Change from throws > Throwable to throws Exception on JUnit methods. > > Change public method to private. > > I'm just add FlakyCategory. GEODE-2395 will remain open to fix up the test. > > I also filed GEODE-2396 "Tests using GfshShellConnectionRule leave behind > gfsh_files directories" > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java > 679f486fc2729643080199da7acce3b60680d88c > > Diff: https://reviews.apache.org/r/56106/diff/ > > > Testing > ------- > > PulseDataExportTest > > > Thanks, > > Kirk Lund > >
