----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56099/#review163587 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java (line 375) <https://reviews.apache.org/r/56099/#comment235059> What if just one of them is null? Do we want to do this "if (userName == null || passwordToUse == null)" instead? - Kirk Lund On Jan. 30, 2017, 11:24 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56099/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 11:24 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2250: gfsh -e connect will throw java.lang.StackOverflowError rather > than prompt for username/password > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > 267746456f0d9cb9df510818c92f2479487aeadd > > Diff: https://reviews.apache.org/r/56099/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Kevin Duling > >
