> On Jan. 30, 2017, 9:52 p.m., Galen O'Sullivan wrote: > > geode-core/src/main/java/org/apache/geode/internal/tcp/TCPConduit.java, > > line 927 > > <https://reviews.apache.org/r/56093/diff/1/?file=1619179#file1619179line927> > > > > The `getLocalAddr` / `getLocalAddress` / (and now) `getAddress` mix > > here is confusing. Do you understand the code well enough to refactor these > > into two or preferably one method?
I'll clean that up in a subsequent commit. The getLocalAddr and getLocalAddress methods are identical, so one can be removed. - Bruce ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56093/#review163575 ----------------------------------------------------------- On Jan. 30, 2017, 7:20 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56093/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 7:20 p.m.) > > > Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Bugs: GEODE-2368 > https://issues.apache.org/jira/browse/GEODE-2368 > > > Repository: geode > > > Description > ------- > > Prior to the membership rewrite for v1.0 we used a different identifier for > the DirectChannel using the class "Stub". In the rewrite we replaced this > with the InternalDistributedMember ID, but that isn't formed until after the > DirectChannel has been booted up and the MembershipManager has finished > joining the distributed system. > > This change set modifies DirectChannel to use the SocketAddress of the server > socket it's created, which is equivalent to the old "Stub" identifier. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/direct/DirectChannel.java > cc88e95ee51c9cb27812c5d4b958acd2c749d110 > > geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java > 1c214e491b05c9f47dd58b3ea371db64fafbc438 > geode-core/src/main/java/org/apache/geode/internal/tcp/TCPConduit.java > 1398070f0a59e1e7b9a254dacfbba33d7801b41d > > Diff: https://reviews.apache.org/r/56093/diff/ > > > Testing > ------- > > A distributedTest run showe that this benign log statement now has the > correct address: > > [locator] [info 2017/01/30 11:04:16.990 PST <RMI TCP > Connection(1)-10.118.33.195> tid=0x14] GemFire P2P Listener started on > PIVOTAL-1127.ad.pivotal.io/10.118.33.195:51785 > > > Thanks, > > Bruce Schuchardt > >
