> On Jan. 27, 2017, 12:23 a.m., Darrel Schneider wrote: > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskLruRegRecoveryJUnitTest.java, > > line 32 > > <https://reviews.apache.org/r/56002/diff/1/?file=1617148#file1617148line32> > > > > also test PR regions
Added test for PR region. > On Jan. 27, 2017, 12:23 a.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java, > > line 127 > > <https://reviews.apache.org/r/56002/diff/1/?file=1617146#file1617146line127> > > > > I think you should add a comment describing how this sys prop changes > > the product behavior Added comment for the new property. - anilkumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56002/#review163210 ----------------------------------------------------------- On Jan. 27, 2017, 12:03 a.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56002/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 12:03 a.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, Ken Howe, and Swapnil > Bawaskar. > > > Repository: geode > > > Description > ------- > > GEODE-1672: out of memory during recovery with overflow regions (heap LRU > configured). > > When recovering the persistent files, GEODE stores the values into temp maps > (for regions) using a background thread, as these maps are not actual > regions, these are not considered/included for LRU eviction, which causes > the system to run OOM. > > The problem is fixed by skipping recovering the values for LRU regiuons. > > A new system property ""disk.recoverLruValues" is added to support reading > values for lru regions. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java > 5affdb5 > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java 32d6e30 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskLruRegRecoveryJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegRecoveryJUnitTest.java > 6a5c338 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionHelperFactory.java > fa68044 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionProperties.java > 19662bf > > Diff: https://reviews.apache.org/r/56002/diff/ > > > Testing > ------- > > Added new test. > Run existing disk tests. > > > Thanks, > > anilkumar gingade > >
