> On Jan. 27, 2017, 7:22 p.m., nabarun nag wrote: > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java, > > line 62 > > <https://reviews.apache.org/r/55956/diff/3/?file=1617268#file1617268line62> > > > > Can a call to afterSecondary at this point cause this to lose the lock. > > > > Also can using a single thread pool for afterPrimary and afterSecondary > > may result in performance issues if we have a lot of buckets and we write a > > test to keep moving buckets or changing the primary/secondary status very > > fast.
Yeah, we need to find a good way to protect against the "primary to secondary to primary to secondary" changes. The single thread pool would have performance impact w.r.t. lucene index creation but prevent any weird locking issues. That or we need to make after primary and after secondary trigger on the main thread and fix those locking issues... - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55956/#review163315 ----------------------------------------------------------- On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55956/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 7:05 a.m.) > > > Review request for geode, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian > zhou. > > > Repository: geode > > > Description > ------- > > Added afterSecondary callback to partition listener to allow cleaning up of > the index repo when the bucket losses primary > Added lock prior to creating the bucket indexes to prevent multiple index > writers from being available at a time > Changed single point of lucene index creation, no longer creating on the fly > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/partition/PartitionListener.java > a534e50 > geode-core/src/main/java/org/apache/geode/internal/cache/BucketAdvisor.java > 7b79bfb > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java > aa29e1b > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/IndexRepositoryFactory.java > c73d64a > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java > f2c7c8f > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LucenePrimaryBucketListener.java > d17b5f2 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneQueryImpl.java > 77333d4 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawIndexRepositoryFactory.java > 2afccf9 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManager.java > 64f2e56 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java > ec94469 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImpl.java > 4e86eb5 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java > 960d794 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/RawLuceneRepositoryManagerJUnitTest.java > 9201180 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/DistributedScoringJUnitTest.java > 225f6ac > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java > 71172f0 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/repository/IndexRepositoryImplJUnitTest.java > 7426fa5 > > Diff: https://reviews.apache.org/r/55956/diff/ > > > Testing > ------- > > geode-lucene:precheckin > > > Thanks, > > Jason Huynh > >
