-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55988/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 3:30 p.m.)
Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund.
Changes
-------
Added junit test to specifically test the two convertErrorAsJson methods.
Modified gradle to require geode-junit for testing.
Bugs: GEODE-2294
https://issues.apache.org/jira/browse/GEODE-2294
Repository: geode
Description
-------
When an error is thrown in the controller, it is supposed to be wrapped in to a
JSON message to return to the client. The problem is a full stacktrace is also
being sent, exceeding the maximum number of bytes allowed in a single http
message. Messages are not flagged as multi-part. And who wants an entire
stacktrace in a response message? Instead, the message should return the
error, but the stacktrace should only be in the server's log.
Diffs (updated)
-----
geode-web-api/build.gradle f74b86fb2cb44ee2c6fe7dc498a6bd11c45f8b6c
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java
b9d2bf4dec5b8d091207b6a98ff30d11ba7cc822
geode-web-api/src/test/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseControllerJUnitTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/55988/diff/
Testing
-------
precheckin running
This changes also fixed a REST test that previously was returning a mysterious
500 error. Now it's returning a proper 404 error.
Thanks,
Kevin Duling
