----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55976/#review163078 -----------------------------------------------------------
Fix it, then Ship it! Looks good! Nice job extending the existing tests and avoiding duplication. geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java (line 110) <https://reviews.apache.org/r/55976/#comment234513> Should these ignored exceptions be here? Why do we need these? geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java (line 156) <https://reviews.apache.org/r/55976/#comment234512> Why is this marked @Deprecated? - Dan Smith On Jan. 26, 2017, 1:47 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55976/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 1:47 a.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-11 > https://issues.apache.org/jira/browse/GEODE-11 > > > Repository: geode > > > Description > ------- > > add dunit tests for index creation tests and queries tests > > > Diffs > ----- > > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationDUnitTest.java > e58f713 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexCreationOnFixedPRDUnitTest.java > PRE-CREATION > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerFixedPRDUnitTest.java > PRE-CREATION > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java > 21c0bbc > > Diff: https://reviews.apache.org/r/55976/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > xiaojian zhou > >
