----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55736/ -----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh Khamesra. Repository: geode Description ------- the add fields have the same behavior and identical code. Refactored the code to use a single method and reduce duplication Diffs ----- geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceHelper.java 39d16a57e geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java 7f510da15 geode-core/src/test/java/org/apache/geode/pdx/JSONPdxClientServerDUnitTest.java 396eb1d13 Diff: https://reviews.apache.org/r/55736/diff/ Testing ------- precheckin - running Thanks, Udo Kohlmeyer
