I agree with Jake - I don't think having a single build process really
serves either side well. In all my time using GemFire/Geode I've never once
had a need to build (or even use) the Native Client component. Given that
the majority of users/developers will be only Java focused, I don't think
'burdening' them with having to also build the native client bits is the
right approach. I imagine this would also suddenly require a whole
different set of dependencies which many folks might not have on their
systems.

--Jens

On Tue, Jan 17, 2017 at 12:48 AM, Avinash Dongre <adon...@apache.org> wrote:

> Thanks Jacob.
> Build goes fine with this change.
>
>
> Thanks
> Avinash
>
>
> On Tue, Jan 17, 2017 at 5:17 AM, Jacob Barrett <jbarr...@pivotal.io>
> wrote:
>
> > Avinash,
> >
> > We just added some changes to the Geode dependency. You should be able to
> > set cmake -DGEODE_ROOT=/path/to/apache-geode. Without that flag set it
> > will
> > look for Geode in:
> >
> >   /geode/bin
> >   /apache-geode/bin
> >   /usr/geode/bin
> >   /usr/apache-geode/bin
> >   /usr/local/geode/bin
> >   /usr/local/apache-geode/bin
> >   /opt/geode/bin
> >   /opt/apache-geode/bin
> >   /opt/local/geode/bin
> >   /opt/local/apache-geode/bin
> >
> >
> > -Jake
> >
> >
> > On Sun, Jan 15, 2017 at 2:24 AM Avinash Dongre <adon...@apache.org>
> wrote:
> >
> > > This is great.
> > >
> > > Need to make following change to PASS the build.
> > >
> > >
> > > diff --git a/src/tests/javaobject/CMakeLists.txt
> > > b/src/tests/javaobject/CMakeLists.txt
> > > index 4924e5c..7f85878 100644
> > > --- a/src/tests/javaobject/CMakeLists.txt
> > > +++ b/src/tests/javaobject/CMakeLists.txt
> > > @@ -9,8 +9,8 @@ get_filename_component(JAVA_HOME ${JAVA_BIN}
> DIRECTORY)
> > >
> > >  # Update the class path.
> > >  set(CMAKE_JAVA_INCLUDE_PATH ${JAVA_HOME}/lib/tools.jar)
> > > -if (GEMFIRE_HOME)
> > > -    LIST(APPEND CMAKE_JAVA_INCLUDE_PATH
> > > ${GEMFIRE_HOME}/lib/geode-core-9.0.0.jar)
> > > +if (DEFINED ENV{GEMFIRE_HOME})
> > > +    LIST(APPEND CMAKE_JAVA_INCLUDE_PATH
> > > $ENV{GEMFIRE_HOME}/lib/geode-core-1.0.0-incubating.jar)
> > >  else()
> > >      LIST(APPEND CMAKE_JAVA_INCLUDE_PATH
> > > "/gemfire/lib/geode-core-9.0.0.jar")
> > >  endif()
> > >
> > >
> > > Also need to update the src/BUILDING.md for instruction to download
> geode
> > > build from [1] and set GEMFIRE_HOME ( which I think should be changed
> to
> > > GEODE_HOME )
> > >
> > >
> >
>

Reply via email to