----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55532/ -----------------------------------------------------------
(Updated Jan. 17, 2017, 10:21 p.m.) Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. Changes ------- do not overwrite security settings when importing, added a test to cover it. Repository: geode Description ------- * When importing cluster config first check if there is any non-empty region * close and re-create cache if no data exists when importing new cluster configuration * put the acquire/release lock inside the ClusterConfigurationService instead of command execution strategy. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java 1d4030a8dedd017a0ab096925055f375bb5d3ef0 geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b301b80a1268c8ad0954e9abe86711cdfe5ac066 geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java PRE-CREATION geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster_config_security.zip PRE-CREATION Diff: https://reviews.apache.org/r/55532/diff/ Testing ------- precheckin successful Thanks, Jinmei Liao
