-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55398/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 12:20 a.m.)
Review request for geode, Jinmei Liao, Jared Stewart, and Kevin Duling.
Changes
-------
Removed unused files. Fixed several test failures. These tests still each have
one failing test: PartitionedRegionQueryDUnitTest, BackupDUnitTest,
ReconnectDUnitTest. So far, I don't know what the connection is between my
changes and these three test cases. They don't use ManagementTestBase or Rule
so it would have to be caused by changes to core dunit classes.
Bugs: GEODE-1930
https://issues.apache.org/jira/browse/GEODE-1930
Repository: geode
Description
-------
I was going to submit this after converting all of the Management dunit tests,
but I've already lost the changes I made to LocatorManagementDUnitTest due to
conflicts with another commit for GEODE-1893. I'd like to merge what I have so
far to develop and then we can cleanup the ManagementTestRule further and
convert the remaineder of Management dunit tests.
There are also a lot of tests using ManagementTestBase in unexpected ways. I
removed those.
Diffs (updated)
-----
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIsAndInterOpsDUnitTest.java
c90a7a4b6d5568e8d25d54f5191648c314a481ed
geode-core/build.gradle 49dd84b387867e0189892ba096d35a2483c0ee37
geode-core/src/main/java/org/apache/geode/management/JVMMetrics.java
127592a5fc75032d430be171d275f6982fc49854
geode-core/src/main/java/org/apache/geode/management/OSMetrics.java
d90c8be1268a5758742ad9e1fd188638de541c9e
geode-core/src/main/java/org/apache/geode/management/internal/SystemManagementService.java
cb755916d86af1d83f6f619fd77abc7147f5a56f
geode-core/src/test/java/org/apache/geode/distributed/DistributedLockServiceDUnitTest.java
277c6046a36e32cc0fb53f6c8c53a02e10c826e1
geode-core/src/test/java/org/apache/geode/internal/cache/ConnectDisconnectDUnitTest.java
de6343304cefa39ac353e8b692f1f10b03ce0de3
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionBucketCreationDistributionDUnitTest.java
ed23f2add324a5402405623972ce1160816371d7
geode-core/src/test/java/org/apache/geode/internal/cache/locks/TXLockServiceDUnitTest.java
14267a4cc910aa37c5ab92eff53dee16d19c80eb
geode-core/src/test/java/org/apache/geode/management/CacheManagementDUnitTest.java
680579d47070a593b00045eec75a5b6a7dd261fa
geode-core/src/test/java/org/apache/geode/management/ClientHealthStatsDUnitTest.java
a3c8b27bb170ef07e24142da66b2d5ccb17cf959
geode-core/src/test/java/org/apache/geode/management/CompositeTypeTestDUnitTest.java
9c33003639751420b505ce0234d64dfe6bd85ffd
geode-core/src/test/java/org/apache/geode/management/DLockManagementDUnitTest.java
86501c31dbca3c06718472c902112cc62301c852
geode-core/src/test/java/org/apache/geode/management/DiskManagementDUnitTest.java
bcfadde1035a4092d130e43cf617cd4da67345c0
geode-core/src/test/java/org/apache/geode/management/DistributedSystemDUnitTest.java
4eaba67db0a9a8a811c511814cdb1236c7400f51
geode-core/src/test/java/org/apache/geode/management/JMXMBeanDUnitTest.java
0feb4c25a957eeeb29a34a90227b01257a92a600
geode-core/src/test/java/org/apache/geode/management/LocatorManagementDUnitTest.java
205ada535dd0e38e008f0443b010877729936d16
geode-core/src/test/java/org/apache/geode/management/ManagementTestBase.java
85d42ee35402fb44282244c75d61caba70491b9e
geode-core/src/test/java/org/apache/geode/management/ManagementTestRule.java
PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/Manager.java
PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/Member.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/OffHeapManagementDUnitTest.java
289d6d73822fbfd4fcbfb2298f7c43afe6df40f9
geode-core/src/test/java/org/apache/geode/management/QueryDataDUnitTest.java
1773a27531331ea3d3169d73246ec0742457f9f1
geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java
fcdc3a416ffc19044f9385d779b362e0b449f4f5
geode-core/src/test/java/org/apache/geode/management/bean/stats/DistributedSystemStatsDUnitTest.java
d2e797ea7b6525a27ed45794c3f620cdc2552f37
geode-core/src/test/java/org/apache/geode/management/internal/beans/QueryDataFunctionApplyLimitClauseTest.java
f4ca2391c9e09956003f59fdb507ba7d5ef2058e
geode-core/src/test/java/org/apache/geode/management/internal/pulse/TestClientIdsDUnitTest.java
94166168f9ba2e05f806383515b2fcb5f1bdfcf2
geode-core/src/test/java/org/apache/geode/management/internal/pulse/TestSubscriptionsDUnitTest.java
7d965173f0b63767ba523c56a4a17a179e073311
geode-core/src/test/java/org/apache/geode/test/dunit/AsyncInvocation.java
460b562e411ca3e25924dc5dde9b0a4db7590820
geode-core/src/test/java/org/apache/geode/test/dunit/Invoke.java
a09f5ff965ec5e705b41b9b94927be919c07afc7
geode-core/src/test/java/org/apache/geode/test/dunit/VM.java
04d29511201fb52b4347c6287f427c3d1a81595f
geode-core/src/test/java/org/apache/geode/test/dunit/Wait.java
f25810e7f84a3f82036f38cc41746ffb9028b792
geode-core/src/test/java/org/apache/geode/test/dunit/cache/internal/JUnit4CacheTestCase.java
037d73c8a366905f09bc32a7be880de5b20d7006
geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java
c54b6acf6d725e561d1a5c568a2c3c1c15225e6a
geode-core/src/test/java/org/apache/geode/test/dunit/rules/DistributedDisconnectRule.java
ddf37c5ffcaa72b4e64bda3e3c0b7453d9edb68e
geode-core/src/test/java/org/apache/geode/test/dunit/rules/DistributedRestoreSystemProperties.java
6b9102ede589361f64a35c2ea6e5f6838be18fc3
geode-core/src/test/java/org/apache/geode/test/dunit/rules/DistributedRule.java
PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/rules/DistributedUseJacksonForJsonPathRule.java
PRE-CREATION
geode-core/src/test/java/org/apache/geode/test/dunit/rules/RemoteInvoker.java
6398e45c06bbec0a568a3fa16a0290f82b347e75
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
8587ea5e34df82036dbca94602ed2276cef73ca8
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt
9626be76c35194e07df10d3ad650cb3d2df4d73a
geode-junit/build.gradle f7e5e4615a3829b9e0c4427add1b2ae66c9e1bed
geode-junit/src/main/java/org/apache/geode/test/junit/rules/UseJacksonForJsonPathRule.java
PRE-CREATION
geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/SerializableExternalResource.java
c76ed19a7c4d3a6b655279958f31a8d8656af060
geode-junit/src/main/java/org/apache/geode/test/junit/rules/serializable/SerializableStatement.java
PRE-CREATION
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/management/LuceneManagementDUnitTest.java
ef4681c1d63daaee308b1bbe69f5b1fbe1d8c7d5
gradle/dependency-versions.properties
7b42e98af3358d5a1542e98ab30cf4ba595dac91
Diff: https://reviews.apache.org/r/55398/diff/
Testing
-------
precheckin in progress
Thanks,
Kirk Lund
