----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55389/#review161442 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java (lines 101 - 102) <https://reviews.apache.org/r/55389/#comment232689> A more general comment, but I think we should come up with a property namespace hierarchy that will make it clear where the "belong" to. maybe something like GEODE/GEMFIRE_PREFIX+"pdx.mapper.sort-json-field-names". geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java (lines 194 - 197) <https://reviews.apache.org/r/55389/#comment232692> Maybe this could be a little "smarter". Maybe you have a DataMapperFactory or PDXDataMapperFactory. Then this could return you the correct dataMapper. This is also a pattern that would allow us to be more extendable. geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java (lines 115 - 118) <https://reviews.apache.org/r/55389/#comment232698> The add****Field method all follow a simple pattern... * log method and field information * add field to a field list Could we not get a generic method out of this and instead of "copy paste" the same logic over and over again... rather call the generic method: insertField(parentMethodName,fieldName,value,FieldType) geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java (lines 293 - 294) <https://reviews.apache.org/r/55389/#comment232699> Provide {} for the if statement. Did spotless not pick this up? geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java (line 321) <https://reviews.apache.org/r/55389/#comment232700> Why would this be a static method? - Udo Kohlmeyer On Jan. 10, 2017, 7:36 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55389/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 7:36 p.m.) > > > Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Added ability to sort json field while convertsing json to pdx. It will help > us reduce number of pdxType id, when document has fields in duifferent order. > One can enable this feature using java system property > gemfire.sort-json-field-names > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/pdx/JSONFormatter.java a96e111 > > geode-core/src/main/java/org/apache/geode/pdx/internal/json/JSONToPdxMapper.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceHelper.java > a91fbd4 > > geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxListHelper.java > caf0dfc > geode-core/src/test/java/org/apache/geode/pdx/JSONFormatterJUnitTest.java > cbe350f > > geode-core/src/test/java/org/apache/geode/pdx/JSONPdxClientServerDUnitTest.java > ae17837 > > Diff: https://reviews.apache.org/r/55389/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
