Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/335#discussion_r95897532
--- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
@@ -32,7 +32,7 @@
</servlet>
<servlet-mapping>
<servlet-name>mvc-dispatcher</servlet-name>
- <url-pattern>/pulse/*</url-pattern>
--- End diff --
It still works because of the "/pulse" webAppContext string passed into
`JettyHelper.addWebApplication()`. Jetty only passes requests for URLs matching
this webAppContext into the Pulse webapp, so if a URL doesn't match /pulse it
never makes it into this servlet mapping. However, maybe we still ought to
leave it as `<url-pattern>/pulse/*</url-pattern>` for clarity of intent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
