----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55383/#review161083 -----------------------------------------------------------
Ship it! Ship It! - Jared Stewart On Jan. 10, 2017, 4:58 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55383/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 4:58 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2261: rename SharedConfig to ClusterConfigurationService > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationEndToEndDUnitTest.java > ec329d3139d949b02c85aee17e544986808ff1d2 > > geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java > c68e50203770294de4322790e75397ee26f052fa > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java > 50f90aae205a21ca62dad946432d26ecc8a10a48 > > geode-core/src/main/java/org/apache/geode/distributed/internal/ServerLocator.java > 928e8d8e6968eb25f634b3be70e6b7e142a367e8 > > geode-core/src/main/java/org/apache/geode/distributed/internal/SharedConfiguration.java > 901b3c97c926242380445977673a47775e929465 > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java > dd734929b1c649d08018e53a0d98ac1f49f4007e > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpHandler.java > f497d628439c6de39f2e62289bcf63dd59037cea > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java > 461d3aca2e8fba7a685df80e8b07c251bf338c49 > > geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java > 67748f65644092d46dab7c8de49cde90f305cc1d > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 943a240055a7a1e6a30116679bd3a9a491ab80dd > > geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocator.java > ddc0542b4a6353c90c018f5a0cbca9ebf88568b1 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java > 41671a4f0f2ee1735b2bc59085a372d7add131bf > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java > 59740e9e58aaa76001dd0e401c28c7d35032e876 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > c53b309314f31878257742473bc2f60064c886fa > > geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java > 708ea6b251d26b65f0d60fd1b8c816b16f73f20b > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/callbacks/ConfigurationChangeListener.java > 6d685b8718aab4cd27202be340d22d2567852233 > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/UploadJarFunction.java > aa211acbcde7c149ff9beb235fbabc028034913a > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/handlers/ConfigurationRequestHandler.java > 309556093c16414191e995cfa4de1c159821989b > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/handlers/SharedConfigurationStatusRequestHandler.java > f866db7b2c80bc91c3070c24cd51a85f5dde77b1 > > geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java > 737c58383b612ec4c98f0a36fd91041ecff193e7 > > geode-core/src/test/java/org/apache/geode/distributed/AbstractLocatorLauncherIntegrationTestCase.java > 120b939b9ae0f782f73d3e003476dadcdba47e09 > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java > 1ad149e066c6115861c50c5b24e9df8b697a9b81 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java > 87e6f666971df5e9f96946b55578b24f19eaa557 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java > f910721312505c8b80b6ba753e42073e1782b96c > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java > 34ffc7c1dbbf659ed1c1e480e6f8ac6b478a9c26 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java > a04bbe8a59647687d0c49e22c9712343ec7ae4dd > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java > 81c4545a191a87527838ffe0c1941baa947aec2f > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java > 98014a4ac67b7e82ca4ca9949d86fc16aabe3dbc > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/SharedConfigurationCommandsDUnitTest.java > 096f0d8d0ce815c1707166682956587efbbbcc60 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java > 73ffbddf1b724b35419f372516651b7da1abdc9d > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationDUnitTest.java > b310c50107c12094d0f194944c6165cc2dc2237e > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationTestUtils.java > 80c510af286db31950d488c91213e5ae8ada4771 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java > a434f05180f488a667538bc65ffc0b4fa244420a > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/utils/XmlUtilsAddNewNodeJUnitTest.java > 66406a74543b3fd166edad88f90b1580c60294b6 > > geode-core/src/test/resources/org/apache/geode/management/internal/configuration/cluster-region.xml > 02cb4bce9365354a8658fba3cc1cb831f5d77604 > > geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java > 882d8d863eb327850eef28e9703603e29b6da868 > > Diff: https://reviews.apache.org/r/55383/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >