----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54948/ -----------------------------------------------------------
(Updated Jan. 9, 2017, 3:47 p.m.) Review request for geode and anilkumar gingade. Changes ------- The previous fix caused a deadlock because of lock inversion on the queueHeadLock and the blockGCLock. This fix introduces a new lock used when modifying or iterating the expiredTombstones. Tests that failed with the previous deadlock are now passing. Bugs: GEODE-2240 https://issues.apache.org/jira/browse/GEODE-2240 Repository: geode Description ------- when adding to the expiredTombstones ArrayList the code now holds a sync on getBlockGCLock. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java 2840134a5466a6bd4552ead334645889d761ce88 Diff: https://reviews.apache.org/r/54948/diff/ Testing ------- precheckin Thanks, Darrel Schneider