----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55329/#review160913 -----------------------------------------------------------
Ship it! Ship It as is now, but let's file a GEODE ticket to transform this into an SPI so the User can plugin their own impl. - Kirk Lund On Jan. 9, 2017, 2:28 a.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55329/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 2:28 a.m.) > > > Review request for geode, Jinmei Liao, John Blum, Kirk Lund, and William > Markito. > > > Repository: geode > > > Description > ------- > > When a user runs `start server` or `start locator` from gfsh > without specifying the member name, gfsh will automatically pick > a random member name. This is useful for automation. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 09d0a67b9f94e22fdeb3b9055a0759b5db805b1d > > geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ThreePhraseGenerator.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherTest.java > 2ddc810b39161e4457ee4bfd498a1fc635652280 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/ThreePhraseGeneratorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/55329/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
