----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55288/ -----------------------------------------------------------
Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. Repository: geode Description ------- GEODE-2261: do not use remote function calls to update the shared configuration Diffs ----- geode-core/src/main/java/org/apache/geode/distributed/internal/DM.java 19381d4c951661b8581befc462044602c090cde2 geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java 5ae54313eb16cf8613ca7dd884beb12c150a2b3b geode-core/src/main/java/org/apache/geode/distributed/internal/SharedConfiguration.java ec22b021675cd40d2a8383d13ede40fa757a2c6f geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java 6db641569449c6cf789ccd8013ae524b7c34bcff geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java 4eac4e9ea0e5660d2f9ec39af30c5ba7e6ab8ff5 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java 358cdc1795b5597995f7bfafd7a589127476d5f5 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 7c887bee0a3346814b6961b4259ddbe668c1d4bd geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 505b6a830d986f367d267e543f2aa876e22c6470 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportSharedConfigurationCommands.java 3a2d94975d4abf94348c9a18386956b4fe7c87a7 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java adb03c6c301303e664c6e7bbdd658bb4cdd6bc84 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java c5e9a4e26a790e20f14174fd3717db03f96dd697 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java ebdae568492931643d6d4de68503985d3819854d geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java dd6a327132a74cd2c481883c9c23ccb6c2d2f5a1 geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportSharedConfigurationFunction.java f20d9d444059e26b19f9468dbb07a0f10ab12e94 geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportSharedConfigurationArtifactsFunction.java beee3db4e41d7748ee7ebeaa07b68ef3c7386b96 geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/LoadSharedConfigurationFunction.java c4fa6eeae319b52a90b90f3df37bbc00d9d2cfa9 geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java 4ae1a1ca739ada17a33d554da856edf283e78b03 geode-core/src/main/java/org/apache/geode/management/internal/configuration/SharedConfigurationWriter.java 2be9873abc0d66506a6b63d58f9c5ff1f792b12f geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/AddJarFunction.java b986372f462cbfa30f7fe615e5b219ccff9db5e9 geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/AddXmlEntityFunction.java c562c9c1a9ea4213168560e30887d4f920d38f5a geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/DeleteJarFunction.java d0d36a86b810206d527b62cdcccc6840c616fb26 geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/DeleteXmlEntityFunction.java 1138d5ff8b277304882bc867aa160cd718ff8bb2 geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/ModifyXmlAndPropertiesFunction.java 97b9ec9fc4065eeeeb8141ed63df08566fd00658 geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/UploadJarFunction.java 7ea868264373cd83519f3bf1f9f21397569f3061 geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/XmlUtils.java cad770c50efa442dc6cb95734819a77e9570cfeb geode-core/src/test/java/org/apache/geode/distributed/internal/SharedConfigurationJUnitTest.java e3e5620610308a30552c14ee41ec607a979e6dcb geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java e2a56fd8ce181b39d35f69db9ca191c28e43f7fe geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandsDUnitTest.java d86cb0be63caabb01179ed11b4015a3c3f172f32 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java 7a75cfa7b402b921a2266a04ced9215428fe54b8 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java 7cf9a3a3fb6f58715919d8469365af6604352ef0 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java 901ed294c8867976c8cec272628b3943cb035f94 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java 6dbd10c30342049c86980203dd40a28ae72fb9c3 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java b1897ba8da8e891eee85e53fb0a8dc1f2b9266e8 geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java 28890b8a5bdb6acb9b8820d4c1d1964012e3ac10 geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java a501235c8903889ab5506843c40df9145d51af48 geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDistributionDUnitTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java cd8500af3d61cc8b5241dc1b7be8d3b142ef8b7a geode-core/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationDUnitTest.java 2e733a7b188ed424717b92e15c7288d6902c5181 geode-core/src/test/java/org/apache/geode/management/internal/configuration/utils/XmlUtilsJUnitTest.java 3992146efe704c98e061739f4305647d2e1ded55 geode-core/src/test/java/org/apache/geode/redis/SetsJUnitTest.java 2d4a9291491933e893c3dd9fbc08aed12151ae21 geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java 9e46ad0cb284bcb50c9da3fc713b8617d10faeb5 geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerConfigurationRule.java PRE-CREATION geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java 04fad5d974df3ded735ed24fe3509e0a06138416 geode-core/src/test/resources/org/apache/geode/distributed/internal/SharedConfigurationJUnitTest.xml geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationDUnitTest.java f73a393cb4e293d3d743cd69eeaceafa4255959c geode-wan/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationExtensionsDUnitTest.java PRE-CREATION geode-wan/src/test/java/org/apache/geode/management/internal/configuration/WanDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/55288/diff/ Testing ------- precheckin running Thanks, Jinmei Liao
