----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55155/#review160526 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Jan. 3, 2017, 10:55 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55155/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 10:55 p.m.) > > > Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Bugs: geode-2155 > https://issues.apache.org/jira/browse/geode-2155 > > > Repository: geode > > > Description > ------- > > I created a test to reproduce the problem by introducing a non-Declarable > cache listener and then initiating a forced-disconnect. cache.xml is > generated and when it's used to rebuild the cache a CacheXmlException is > thrown, reliably reproducing the problem. > > The fix is to simply catch the CacheXmlException in > InternalDistributedSystem.reconnect() and terminate reconnection attempts. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > 3d51fb92f3f00bb796bca955b32465cdc2e7e768 > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 7f5fa328f3542aca89cd51a4cb44b1aef1f08f84 > geode-core/src/test/java/org/apache/geode/cache30/ReconnectDUnitTest.java > e324576005ef9530a86ab7b2854c8d4b2a4d9e03 > > Diff: https://reviews.apache.org/r/55155/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
