----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54916/#review159997 -----------------------------------------------------------
Fix it, then Ship it! It looks good, but I think we really need to clean up this getSenderStats method at some point because that's a lame API. geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 103) <https://reviews.apache.org/r/54916/#comment231014> This getSenderStats method looks like it needs some work - it's returning an list where you have to know the index of the stat? - Dan Smith On Dec. 22, 2016, 6:38 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54916/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 6:38 p.m.) > > > Review request for geode, nabarun nag and Dan Smith. > > > Repository: geode > > > Description > ------- > > Fixes to make the test less timing based. > > > Diffs > ----- > > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java > 3ed867a > > Diff: https://reviews.apache.org/r/54916/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
