[
https://issues.apache.org/jira/browse/GEODE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762675#comment-15762675
]
ASF subversion and git services commented on GEODE-1272:
--------------------------------------------------------
Commit 341a359e00a9ba2f9c74e1dc4fee38fc53f78b3c in geode's branch
refs/heads/develop from [~upthewaterspout]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=341a359 ]
GEODE-1272 Don't deserialize PDX objects when creating an index
Setting the flag to prevent deserialization of PDX objects while
populating an index that is defined on a partitioned region. We were
setting this flag in the member that initially created the index, but
not in other members that receive the IndexCreationMessage.
This closes #318
> IndexManager.populateIndexes(Collection) may deserialize pdx to domain objects
> ------------------------------------------------------------------------------
>
> Key: GEODE-1272
> URL: https://issues.apache.org/jira/browse/GEODE-1272
> Project: Geode
> Issue Type: Bug
> Components: querying
> Reporter: Darrel Schneider
> Assignee: Dan Smith
>
> Looking at the IndexManager.populateIndexes I see it iterating over all the
> entries in a region and adding each entry to each index. What is unclear is
> if this code correctly calls DefaultQuery.setPdxReadSerialized before
> accessing the value from the entry. Please verify that when this code is used
> it will not deserialize pdx to domain object.
> Note that the code currently calls RegionEntry.getValue for every entry and I
> thought that might be a problem. But since getValue just returns the
> VMCachedDeserializable and does not try to deserialize the value it wraps it
> does not cause a problem. So the only issue would be what happens each each
> entry is passed to AbstractIndex.addIndexMapping.
> I looked the callers of IndexManager.populateIndexes and could not find them
> calling DefaultQuery.setPdxReadSerialized.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
