[
https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15756817#comment-15756817
]
ASF GitHub Bot commented on GEODE-165:
--------------------------------------
GitHub user davinash opened a pull request:
https://github.com/apache/geode/pull/322
[GEODE-165] Fix for Add build support for generating antlr classes from
grammar
1. Updated spotless configuration to exclude 'generated-src' directory.
2. Removed
OQLLexerTokenTypes.java
OQLLexerTokenTypes.txt
OQLParser.java
OQLLexer.java
3. Removed above files entry from rat
Thanks @metatype for helping in gradle configuration.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/geode feature/GEODE-165
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit d68d32c63fa90254b34116320bc2889a366c12c3
Author: adongre <adon...@apache.org>
Date: 2016-12-16T08:47:10Z
GEODE-165: Removed OQL generated files and added the target into
geode-core/build.gradle.
commit e83732fdd3890783c991a81b824a5c4207a2ddaf
Author: adongre <adon...@apache.org>
Date: 2016-12-17T10:38:55Z
GEODE-165 : Updating spotless configuration to exclude 'generated-src'
directory.
----
> Add build support for generating antlr classes from grammar
> -----------------------------------------------------------
>
> Key: GEODE-165
> URL: https://issues.apache.org/jira/browse/GEODE-165
> Project: Geode
> Issue Type: Bug
> Components: build
> Reporter: Dan Smith
> Assignee: Mark Bretl
>
> The OQL engine currently uses antlr to generate some parsing classes from
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/oql.g
> These are the generated classes. They are currently checked into the source.
> OQLLexer.java
> OQLLexerTokenTypes.java
> OQLLexerTokenTypes.txt
> OQLParser.java
> They can be generated manually by running antlr.Tool on the provided grammar.
> cd gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/
> java -cp antlr.jar antlr.Tool oql.g
> We should add support to the gradle build to generate these classes.
> In my opinion we should also remove the checked in classes. With gradle we
> can configure things so that the gradle eclipse target will generate these
> classes and make them available to the IDE as well. Look at
> gemfire-core/build.gradle for how we do this with the version properties file:
> sourceSets {
> main {
> output.dir(generatedResources, builtBy: 'createVersionPropertiesFile')
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
