[ 
https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15739009#comment-15739009
 ] 

Kirk Lund commented on GEODE-2203:
----------------------------------

[~dalyssakim] For some reason I'm unable to assign this to you as well -- I'm 
guessing it's related to permissions but I'll try to find out on Monday.

For the Geode1.0 release we removed geode-joptsimple module which was a fork of 
jopt-simple. GFSH was using this fork to perform validation of command 
arguments. When we switched to a dependency on a regular binary release of 
jopt-simple, we lost that detailed validation. The code in GFSH that used the 
old geode-joptsimple is still there and all of the GFSH code needs quite a bit 
of cleanup. [~jinmeiliao] has a branch where she's replacing the use of 
jopt-simple with using just spring shell for parsing -- this might be something 
to keep in mind or you might even want to checkout her branch.

> gfsh status locator/server - Give more descriptive output on empty parameter
> ----------------------------------------------------------------------------
>
>                 Key: GEODE-2203
>                 URL: https://issues.apache.org/jira/browse/GEODE-2203
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Alyssa Kim
>            Assignee: Mark Bretl
>            Priority: Minor
>
> Currently, executing some status commands in gfsh without valid parameters 
> gives a vague explanation/output that might be misleading. Although we have 
> help <command_name> for usage description, displaying 'null' as an output 
> might not be the best idea.
> Current Result
> {code}
> gfsh>status locator
> null
> {code}
> {code}
> gfsh>status server
> Server in 
> C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin
>  on null is currently not responding.
> {code}
> Improvement
> {code}
> gfsh>status locator
> SYNTAX
>     status locator [--name=value] [--host=value] [--port=value] [--pid=value]
> Use help status locator to display detailed usage information
> {code}
> {code}
> gfsh>status server
> SYNTAX
>     status server [--name=value] [--pid=value] [--dir=value]
> Use help status server to display detailed usage information
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to