Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/311#discussion_r91813763
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -668,13 +747,45 @@ public String getJavaVersion() {
*
* @return a List of String value each representing an argument passed
to the JVM of the GemFire
* service.
+ *
* @see java.lang.management.RuntimeMXBean#getInputArguments()
*/
public List<String> getJvmArguments() {
return jvmArguments;
}
/**
+ * Gets the arguments passed to the JVM process that is running the
GemFire service.
+ *
+ * @return a List of String value each representing an argument passed
to the JVM of the GemFire
+ * service.
+ *
+ * @see java.lang.management.RuntimeMXBean#getInputArguments()
+ */
+ public List<String> getRedactedJvmArguments() {
--- End diff --
This method does essentially the same thing as `Gfsh#getRedactedCmdlet`. I
think extracting this logic into a method of a small LogRedactor class which
you can call from both places might clean things up a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
