-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54542/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 10:03 p.m.)


Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Bugs: GEODE-2191
    https://issues.apache.org/jira/browse/GEODE-2191


Repository: geode


Description
-------

* Added a new test that generates random strings, and attempts to serialize and 
deserialize them looking for differences or errors.


Diffs (updated)
-----

  
geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerRandomizedJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/54542/diff/


Testing
-------

This is a new test; I've run it both from IntelliJ and as a part of the test 
suite. I filed GEODE-2191 for this; I'm not sure if a new JIRA is strictly 
necessary for any new changes but it does seem to be encouraged.

I don't know of any random string generator that is already available in the 
codebase; had there been one I would have used it rather than rolling my own. 
We could eventually use something like 
[junit-quickcheck](https://github.com/pholser/junit-quickcheck) for these types 
of tests.


Thanks,

Galen O'Sullivan

Reply via email to