----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54503/#review158462 -----------------------------------------------------------
Ship it! +1 for using Map.merge with logicalAnd. Pretty cool. - Barry Oglesby On Dec. 7, 2016, 11:14 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54503/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 11:14 p.m.) > > > Review request for geode, Barry Oglesby and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Gateway senders may or may not be connected, depending on what is going > on with the underlying queue. If a sender is a secondary, it may be > disconnected because it doesn't need to send anything. Even primaries > may be disconnected for periods of time if the connection is lost when > there is nothing in the queue. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/beans/DistributedSystemBridge.java > 3016277715864b4b66b25d9dcffc8ef7053e5467 > > geode-wan/src/test/java/org/apache/geode/management/WANManagementDUnitTest.java > 9a6cc104a1368fa762bffd1efa1978f007819604 > > Diff: https://reviews.apache.org/r/54503/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
