----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54436/#review158220 -----------------------------------------------------------
Ship it! I know one thing Region.query is used for is for querying the local data within the context of a function. Maybe we need to find a better way to expose that capability through the query service if we are going to deprecate/remove capabilities from region.query. - Dan Smith On Dec. 6, 2016, 7:01 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54436/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 7:01 p.m.) > > > Review request for geode, Barry Oglesby, nabarun nag, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Added deconstruction/reconstruction code to server side region.query > execution to make it consistent with client side. > > At some point I think we were going to deprecate the ability to execute a > full select query string from the region.query() method itself. > > Minor prevention of executing a full query with a region that does not match > the current region name and prevents multiple region queries from being > executed from region.query. Long term we should restrict this even more to > prevent security issues. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/cache/Region.java be70157 > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 4349359 > geode-core/src/test/java/org/apache/geode/cache/query/RegionJUnitTest.java > 1ba858b > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/RemoteQueryDUnitTest.java > 8088374 > > geode-core/src/test/java/org/apache/geode/cache/query/partitioned/PRInvalidQueryJUnitTest.java > 6239b54 > > Diff: https://reviews.apache.org/r/54436/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
