----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54323/#review157854 -----------------------------------------------------------
Fix it, then Ship it! geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceImpl.java (line 1058) <https://reviews.apache.org/r/54323/#comment228466> I think this could use computeIfAbsent rather than get followed by putIfAbsent. - Dan Smith On Dec. 2, 2016, 9:47 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54323/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 9:47 p.m.) > > > Review request for geode and Dan Smith. > > > Repository: geode > > > Description > ------- > > Removing from the map when a cq is closed > Did not protect this map because "misses" or missing entries will just be > added next lookup. > > > Diffs > ----- > > > geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceImpl.java > 1414e90 > > geode-cq/src/test/java/org/apache/geode/cache/query/internal/cq/CqServiceUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/54323/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
