[
https://issues.apache.org/jira/browse/GEARPUMP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220004#comment-16220004
]
ASF GitHub Bot commented on GEARPUMP-359:
-----------------------------------------
GitHub user huafengw opened a pull request:
https://github.com/apache/incubator-gearpump/pull/234
[GEARPUMP-359] Fix OutputWatermark advancing logic in Subscription
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been
updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huafengw/incubator-gearpump subs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #234
----
commit 311e09b28ebe8ac8525b447e831615065dcc541c
Author: huafengw <[email protected]>
Date: 2017-10-26T05:52:39Z
[GEARPUMP-359] Fix OutputWatermark advancing logic in Subscription
----
> The premature OutputWatermark advancing logic in Subscription is not right
> --------------------------------------------------------------------------
>
> Key: GEARPUMP-359
> URL: https://issues.apache.org/jira/browse/GEARPUMP-359
> Project: Apache Gearpump
> Issue Type: Bug
> Reporter: Huafeng Wang
> Assignee: Huafeng Wang
>
> {{Subscription}} will update processingWatermark when sending a message and
> update outputWatermark when receiving an Ack message. It will cause
> prematurely updating the outputWatermark in such scenario: the
> {{Subscription}} already sent 200 messages to downstream and now the
> processingWatermark is 200th message's watermark, then it receives the first
> 100 messages' Ack and it will advance the outputWatermark to 200th message's
> watermark, not the 100th one, which is wrong.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
