Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/226#discussion_r141637090
  
    --- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala
 ---
    @@ -73,6 +73,25 @@ case class AndThen[IN, MIDDLE, OUT](left: 
WindowRunner[IN, MIDDLE],
       }
     }
     
    +class DirectWindowRunner[IN, OUT](fnRunner: FunctionRunner[IN, OUT])
    --- End diff --
    
    Maybe change `WindowRunner` to a more generic name? Then 
`DirectWindowRunner` can be a non-window runner.


---

Reply via email to