[GitHub] incubator-gearpump issue #223: [GEARPUMP-349] Optimize Graph topologicalOrde...

[manuzhang]

Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/223
  
    We also do an extra check for cycle here. Can it be removed ?
    
    ```scala
        if (dag.hasCycle()) {
          LOG.warn(s"Detected cycles in DAG of application $name!")
        }
    
        val indices = 
dag.topologicalOrderWithCirclesIterator.toList.zipWithIndex.toMap
    ```


---