[
https://issues.apache.org/jira/browse/GEARPUMP-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112716#comment-16112716
]
ASF GitHub Bot commented on GEARPUMP-338:
-----------------------------------------
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/208
R: @huafengw
> Improve time related types and constants
> ----------------------------------------
>
> Key: GEARPUMP-338
> URL: https://issues.apache.org/jira/browse/GEARPUMP-338
> Project: Apache Gearpump
> Issue Type: Improvement
> Affects Versions: 0.8.4
> Reporter: Manu Zhang
> Assignee: Manu Zhang
> Fix For: 0.8.5
>
>
> Currently, there is a type {{TimeStamp}} in package object {{gearpump}}. It's
> unclear what the time unit is, seconds or milliseconds. There are also
> constants {{MAX_TIME_MILLIS}} and {{MIN_TIME_MILLIS}} for maximum and minimum
> valid timestamps in milliseconds. All of them are not easy to find out and
> import from the package object.
> Propose to move them into a new object singleton {{Time}} and rename type
> {{TimeStamp}} to {{MilliSeconds}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
