Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/198
@yanghua Thanks, this is a great effort. I left several comments after a
quick glance through.
More generally,
1. This is a big PR with new interfaces being introduced. Could we split it
into smaller ones ?
2. I don't see the `WordCount` examples a strong use case for `State`. I'm
thinking about questions like "what is the state used for ?", "can it be
replaced with a stateless one ?"
3. I see some existing classes copied under `refactor`. Can you modify the
existing codes directly such that review will easier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
