[
https://issues.apache.org/jira/browse/GEARPUMP-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882172#comment-15882172
]
ASF GitHub Bot commented on GEARPUMP-282:
-----------------------------------------
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/160#discussion_r102893853
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -48,8 +48,12 @@ class RunningApplication(val appId: Int, master:
ActorRef, timeout: Timeout) {
* If failed, an exception will be thrown out
*/
def waitUntilFinish(): Unit = {
+ this.waitUntilFinish(INF_TIMEOUT)
+ }
+
+ def waitUntilFinish(timeout: Timeout): Unit = {
--- End diff --
better to use `java.time.Duration`
> Allow user to configure wait duration for a running application
> ---------------------------------------------------------------
>
> Key: GEARPUMP-282
> URL: https://issues.apache.org/jira/browse/GEARPUMP-282
> Project: Apache Gearpump
> Issue Type: Improvement
> Components: client
> Reporter: Manu Zhang
> Assignee: Huafeng Wang
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
