[
https://issues.apache.org/jira/browse/GEARPUMP-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512283#comment-15512283
]
ASF GitHub Bot commented on GEARPUMP-204:
-----------------------------------------
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/86#discussion_r79979272
--- Diff:
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
---
@@ -148,11 +158,24 @@ object HBaseSink {
val userName = userConfig.getString(HBASE_USER)
if (userName.isEmpty) {
ConnectionFactory.createConnection(configuration)
+
} else {
val user = UserProvider.instantiate(configuration)
.create(UserGroupInformation.createRemoteUser(userName.get))
ConnectionFactory.createConnection(configuration, user)
}
+
+ }
--- End diff --
need a blank line here
> Add unit test for external_hbase module
> ---------------------------------------
>
> Key: GEARPUMP-204
> URL: https://issues.apache.org/jira/browse/GEARPUMP-204
> Project: Apache Gearpump
> Issue Type: Improvement
> Reporter: Manu Zhang
> Assignee: Kaifang Bao
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
