On Tue, Apr 03, 2018 at 05:19:06PM +0100, Ferruh Yigit wrote: > On 4/3/2018 1:41 PM, Olivier Matz wrote: > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c > > b/drivers/net/mvpp2/mrvl_ethdev.c > > index 6ab515ca9..87748f789 100644 > > --- a/drivers/net/mvpp2/mrvl_ethdev.c > > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > > @@ -987,7 +987,7 @@ mrvl_mac_addr_remove(struct rte_eth_dev *dev, uint32_t > > index) > > return; > > > > if (priv->isolated) > > - return; > > + return -ENOTSUP; > > > > ret = pp2_ppio_remove_mac_addr(priv->ppio, > > dev->data->mac_addrs[index].addr_bytes); > > @@ -996,6 +996,8 @@ mrvl_mac_addr_remove(struct rte_eth_dev *dev, uint32_t > > index) > > &dev->data->mac_addrs[index]); > > RTE_LOG(ERR, PMD, "Failed to remove mac %s\n", buf); > > } > > + > > + return ret; > > } > > I guess mrvl_mac_addr_remove() updated by mistake?
erf... that explains why I had to do the modification twice :D Thanks for spotting it, will send an update.
