14/11/2017 09:24, Olivier MATZ:
> On Tue, Nov 14, 2017 at 06:09:35AM +0100, Thomas Monjalon wrote:
> > > > >> Update types of variables to correspond to nb_segs type change from
> > > > >> uint8_t to uint16_t.
> > > > >>
> > > > >> Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments")
> > > > >> Cc: [email protected]
> > > > >>
> > > > >> Signed-off-by: Ilya V. Matveychikov <[email protected]>
> > > Acked-by: Olivier Matz <[email protected]>
> >
> > Is there a real benefit to get it in 17.11?
>
> Without this patch:
>
> - cloning a mbuf with more than 255 segments will create an mbuf with an
> invalid number of segments.
>
> - chaining mbufs with rte_pktmbuf_chain() will return an error if the
> resulting mbuf has more than 255 segments.
>
> > Is there a risk?
>
> It is not so critical, since manipulating mbufs with a large number of
> segments is a very specific use case.
>
> But the risk seems low, I think we can put it in 17.11.
OK, applied, thanks
