On 4/20/2017 10:01 AM, Nicolas Dichtel wrote: > pci_enable_msix() will be removed in kernel 4.12. The new API is available > since linux 4.8, thus let's use it. > > Link: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=aff171641d18 > Link: > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=4244de1c64de > Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> > Reviewed-by: David Marchand <david.march...@6wind.com>
<...> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0) > +#define HAVE_PCI_ENABLE_MSIX > +#endif Would you mind moving this check to the end of the file, to preserve version check in increasing order (although I aware some doesn't fit this)? When above done: Acked-by: Ferruh Yigit <ferruh.yi...@intel.com>