On Fri, 6 Nov 2026 13:50:50 -0800 Stephen Hemminger <[email protected]> wrote:
> Info (pre-existing, not introduced by this patch): ntb_queue_setup() > still leaks on two paths the commit message does not cover. [...] > (ntb_txq_release()/ntb_rxq_release() log an error on NULL, so a > NULL check on each would be needed for the last release.) Fine as a > follow-up. Hi Stephen, Thanks for the review. The follow-up is included in v3 as patch 16, "raw/ntb: fix queue leaks on setup", as you suggested: the shared conf is checked first, the previous queues are released before a new setup, the Tx queue is released if the Rx setup fails, and the release helpers ignore NULL queues. In addition, the setup returns -EBUSY when the device is started, as releasing the queues under the data path would be a use after free. Hi David, Sorry for the trouble with v2. The patches were generated without threading, so each one replied to the v1 cover letter instead of the v2 one. Patchwork then split the series and the CI could not apply it. v3 is resent with proper threading, rebased on main. Patches 1-15 are unchanged from v2, and patch 16 is the follow-up above. I will check that the CI passes on v3. The v1 and v2 series in patchwork can be marked as superseded. Thanks, Raghavendra
