On Mon, Nov 02, 2026 at 08:10:37AM +0000, Anurag Mandal wrote:
> ice_acl_prof_init() allocates a flow segment to add the ACL profiles,
> but only frees it on the error path, so it leaks on every ACL engine
> init.
>
> ice_flow_add_prof() copies the segments, so the buffer is only needed
> while adding the profiles.
>
> Allocate it on the stack instead, which removes the need to free it.
>
> Fixes: 40d466fa9f76 ("net/ice: support ACL filter in DCF")
> Cc: [email protected]
>
> Signed-off-by: Anurag Mandal <[email protected]>
> ---
> drivers/net/intel/ice/ice_acl_filter.c | 46 +++++++++++---------------
> 1 file changed, 20 insertions(+), 26 deletions(-)
>
Acked-by: Bruce Richardson <[email protected]>
- Re: [PATCH 1/7] net/ice: fix DDP package double free... Bruce Richardson
- Re: [PATCH 1/7] net/ice: fix DDP package double ... Bruce Richardson
- [PATCH 4/7] net/ice: fix main VSI leak on init failure Anurag Mandal
- Re: [PATCH 4/7] net/ice: fix main VSI leak on init f... Bruce Richardson
- [PATCH v2 0/7] net/ice: fix memory leaks Anurag Mandal
- [PATCH v2 4/7] net/ice: fix main VSI leak on init fa... Anurag Mandal
- [PATCH v2 6/7] net/ice: fix FDIR resource leak on se... Anurag Mandal
- [PATCH v2 2/7] net/ice: fix resource leaks on port c... Anurag Mandal
- Re: [PATCH v2 2/7] net/ice: fix resource leaks o... Bruce Richardson
- [PATCH v2 7/7] net/ice: fix ACL profile segment leak Anurag Mandal
- Re: [PATCH v2 7/7] net/ice: fix ACL profile segm... Bruce Richardson
- [PATCH v2 5/7] net/ice: fix MAC and VLAN filter leak... Anurag Mandal
- [PATCH v2 1/7] net/ice: fix DDP package double free ... Anurag Mandal
- Re: [PATCH v2 0/7] net/ice: fix memory leaks Bruce Richardson

