On Fri, Sep 25, 2026 at 10:50:49AM +0000, Bruce Richardson wrote: > This documentation should be squashed into the prevous patch adding the > support. See also one additional comment below.
Done - in v2 the documentation, release note and MAINTAINERS update are squashed into the AMD driver patch, so the series is now 2 patches. > > +The AMD NTB hardware exposes two memory windows (BAR23 and BAR45), 16 > > +doorbells and a single shared 16-register scratchpad bank. The scratchpad > > +bank is split into two disjoint 8-register sets, one owned by each side, so > > +the driver uses a packed handshake layout that fits within 8 registers. > > + > > The documentation needs an update on the alignment requirements and > handling - either the need for the new alignment API if one is added as I > suggested, or else details on how the app needs to handle it itself (which > is less preferable). Added. v2 adds the new rte_pmd_ntb_get_mem_align() API (as you suggested), and the guide now documents the outbound translation window constraint and instructs applications to reserve each memory window memzone with the alignment returned by that API, pointing at the ntb_fwd example as the reference usage. Thanks, Raghavendra
