> Subject: [PATCH v3 14/15] net/ice: enable context desc offloads for vector Tx
> 
> Use the context descriptor Tx vector paths from intel/common in ice
> driver to enable more offloads on the vector path for ice driver.
> 
> Signed-off-by: Bruce Richardson <[email protected]>
> Acked-by: Ciara Loftus <[email protected]>
> ---
>  doc/guides/nics/features/ice.ini            |  8 +++---
>  doc/guides/rel_notes/release_26_11.rst      |  6 ++++
>  drivers/net/intel/ice/ice_ethdev.h          |  3 ++
>  drivers/net/intel/ice/ice_rxtx.c            | 31 ++++++++++++++++++---
>  drivers/net/intel/ice/ice_rxtx.h            | 11 ++++++++
>  drivers/net/intel/ice/ice_rxtx_vec_avx2.c   | 24 ++++++++++++++++
>  drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 24 ++++++++++++++++
>  7 files changed, 99 insertions(+), 8 deletions(-)
> 
> diff --git a/doc/guides/nics/features/ice.ini 
> b/doc/guides/nics/features/ice.ini
> index 893d09e9ec..8674b588ed 100644
> --- a/doc/guides/nics/features/ice.ini
> +++ b/doc/guides/nics/features/ice.ini
> @@ -13,7 +13,7 @@ Link status          = Y
>  Link status event    = Y
>  FEC                  = Y
>  Rx interrupt         = Y
> -Fast mbuf free       = P
> +Fast mbuf free       = Y
>  Free Tx mbuf on demand = Y
>  Queue start/stop     = Y
>  Burst mode info      = Y
> @@ -33,12 +33,12 @@ VLAN filter          = Y
>  Traffic manager      = Y
>  CRC offload          = Y
>  VLAN offload         = Y
> -QinQ offload         = P
> +QinQ offload         = Y

I think this should stay as P because the vector Rx paths
don't support QINQ strip.

>  L3 checksum offload  = Y
>  L4 checksum offload  = Y
>  Timestamp offload    = P
> -Inner L3 checksum    = P
> -Inner L4 checksum    = P
> +Inner L3 checksum    = Y
> +Inner L4 checksum    = Y

Both of these are OK. Although I've noticed that Inner L4 checksum
aka RTE_ETH_RX_OFFLOAD_OUTER_UDP_CKSUM isn't advertised
correctly in the path offload masks / rx_offload_capa so I will submit
a separate patch to fix that.

>  Packet type parsing  = Y
>  Timesync             = Y
>  Rx descriptor status = Y
> diff --git a/doc/guides/rel_notes/release_26_11.rst
> b/doc/guides/rel_notes/release_26_11.rst
> index 6c29513041..c1c51c62ec 100644
> --- a/doc/guides/rel_notes/release_26_11.rst
> +++ b/doc/guides/rel_notes/release_26_11.rst
> @@ -69,6 +69,12 @@ New Features
>    Added ``fdir_buffer_size`` devarg to select the Flow Director table size
>    (``64k``, ``128k`` or ``256k``) at probe time. The default remains ``64k``.
> 

Reply via email to