On Tue, 1 Sep 2026 11:05:11 +0800 [email protected] wrote: > From: Jie Liu <[email protected]> > > This series updates the SXE2 poll mode driver (drivers/net/sxe2) and > its common library (drivers/common/sxe2), fixing issues found in the > previous version and re-aligning the driver with the reference > implementation.
Overall the patch series is in good shape. I was in process of merging to net-next and resolving a couple of trivial conflicts. I noticed that patch 8 is adding a bunch of paranoid checks that around dev_ops. The dev_ops->dev_close check is dead code: dev_ops points at the driver's static ops struct, so if dev_ops is set, dev_close is set. If there is a path where vf_rep_eth_dev[i] is non-NULL but dev_ops is NULL, the bug is on the init side: the failure path is publishing a half-initialized port. Fix that to not store the pointer until init succeeds (or clear it on error), rather than null-checking at teardown. Please identify the actual failure sequence in the commit message.
