This series addresses code analysis defects in the common/sfc_efx/base library.
The first four patches fix excessive stack consumption in MCDI helper functions, each exceeding 1 KB on-stack, by switching to heap-allocated payload buffers. The remaining ten patches correct SAL annotations, add assertions and bounds checks across netport and filter helpers to address uninitialised memory, buffer overrun, and potential dereference issues. The final patch widens loop variable types to address a CodeQL warning. v3: - addressed https://mails.dpdk.org/archives/dev/2026-August/343201.html -- patches 01-04: switched to EFX_MCDI_BUF_SIZE -- patch 05: replaced the unreachable NULL guard with EFSYS_ASSERT; corrected the commit message -- patches 09, 13: moved __success to the declaration line -- patch 11: added stride and count bounds check before the loop -- patch 13: documented the TECH_AUTO default behaviour v2: - note for the future AI reviews: apply this on top of the 'next-net-main' branch - addressed https://mails.dpdk.org/archives/dev/2026-August/343072.html -- fixed the MAC_STATISTICS_DESCRIPTOR_OUT_MORE_ENTRIES accessor -- fixed the FEC hardware enum selection from the software mask -- remaining notes do not seem to point at factual defects Andy Moreton (14): common/sfc_efx/base: reduce stack in RSS context table write common/sfc_efx/base: reduce stack in get addr regions MCDI common/sfc_efx/base: reduce stack in set addr regions MCDI common/sfc_efx/base: reduce stack in netport stat describe common/sfc_efx/base: fix filter saved spec handling common/sfc_efx/base: fix annotations in client MAC addr get common/sfc_efx/base: fix annotations in HW-SW mask converter common/sfc_efx/base: fix annotations in get fixed port props common/sfc_efx/base: fix annotations in SW-HW enum converter common/sfc_efx/base: fix annotation in netport stat describe common/sfc_efx/base: fix flex array in netport stat describe common/sfc_efx/base: fix filter in SW-HW mask converter common/sfc_efx/base: rework SW mask to HW enum converter common/sfc_efx/base: cleanup wider type comparisons in loops drivers/common/sfc_efx/base/ef10_filter.c | 7 +- drivers/common/sfc_efx/base/ef10_mcdi.c | 2 +- drivers/common/sfc_efx/base/ef10_nvram.c | 4 +- drivers/common/sfc_efx/base/ef10_rx.c | 23 ++- drivers/common/sfc_efx/base/efx.h | 3 +- drivers/common/sfc_efx/base/efx_bootcfg.c | 2 +- drivers/common/sfc_efx/base/efx_mcdi.c | 51 +++++-- drivers/common/sfc_efx/base/efx_np.c | 167 +++++++++++++--------- drivers/common/sfc_efx/base/mcdi_mon.c | 2 +- 9 files changed, 168 insertions(+), 93 deletions(-) -- 2.47.3
