> Subject: Re: [PATCH 2/2] net/iavf: rename LLDP Tx devarg > > On Mon, Aug 10, 2026 at 02:03:54PM +0000, Ciara Loftus wrote: > > Now that the dynamic mbuf field method has been removed, packet type is > > the only mechanism used to detect LLDP packets on the transmit path. > > Using the word 'ptype' in the 'enable_ptype_lldp' devarg is therefore > > unnecessary and an implementation detail that no longer needs to be > > exposed to users. > > > > Add an 'enable_lldp' devarg but keep 'enable_ptype_lldp' as a deprecated > > alias that maps to the same setting and emits a warning when used. If > > both are supplied, 'enable_lldp' takes precedence. The > > 'enable_ptype_lldp' devarg will be removed in a future release. > > > I wonder if it's just better to implement a hard failure for use of the > legacy devarg? The old devarg was only present for a release or two, so > shouldn't be that common and its use implies an app or script running an > app that hasn't been properly updated to latest release. > > Also, is it worth throwing a warning on dev probe or start if the LLDP > dynamic mbuf field is present? It's again a sign that an app hasn't been > updated properly. [I don't think we can hard-fail in this case].
+1 for both recommendations. I've posted a v2 with those implemented. Thanks, Ciara > > /Bruce
