Starting with MCFW version 1.4.0.8, Medford4 adapters support the use of the netport MCDI for port configuration by a VF; however, the MCDI which retrieves fixed port properties is not permitted for use by VFs.
Fill in dummy values sufficient for the DPDK driver to start on a VF. Signed-off-by: Ivan Malov <[email protected]> Reviewed-by: Andy Moreton <[email protected]> --- drivers/common/sfc_efx/base/efx_np.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/drivers/common/sfc_efx/base/efx_np.c b/drivers/common/sfc_efx/base/efx_np.c index 5f5ec86647..e05e2cb487 100644 --- a/drivers/common/sfc_efx/base/efx_np.c +++ b/drivers/common/sfc_efx/base/efx_np.c @@ -240,6 +240,7 @@ efx_np_get_fixed_port_props( __out_opt uint32_t *sup_cap_maskp, __out_opt efx_qword_t *loopback_cap_maskp) { + const efx_nic_cfg_t *encp = &enp->en_nic_cfg; EFX_MCDI_DECLARE_BUF(payload, MC_CMD_GET_FIXED_PORT_PROPERTIES_IN_LEN, MC_CMD_GET_FIXED_PORT_PROPERTIES_OUT_V2_LEN); @@ -247,6 +248,28 @@ efx_np_get_fixed_port_props( efx_mcdi_req_t req; efx_rc_t rc; + /* VFs do not allow access to the fixed port data. */ + if (EFX_PCI_FUNCTION_IS_VF(encp)) { + if (sup_cap_maskp != NULL) { + /* + * Indicate a dummy link speed mode, as the + * DPDK driver expects to see at least one. + */ + *sup_cap_maskp = 1U << EFX_PHY_CAP_1000FDX; + + /* + * Indicate three basic capabilities that + * a VF cannot manage, but that can be + * safely assumed to be available. + */ + *sup_cap_maskp |= 1U << EFX_PHY_CAP_PAUSE; + *sup_cap_maskp |= 1U << EFX_PHY_CAP_ASYM; + *sup_cap_maskp |= 1U << EFX_PHY_CAP_AN; + } + + return (0); + } + req.emr_out_length = MC_CMD_GET_FIXED_PORT_PROPERTIES_OUT_V2_LEN; req.emr_in_length = MC_CMD_GET_FIXED_PORT_PROPERTIES_IN_LEN; req.emr_cmd = MC_CMD_GET_FIXED_PORT_PROPERTIES; @@ -1048,10 +1071,6 @@ efx_np_attach( if (rc != 0) goto fail1; - /* - * FIXME: This may need revisiting for VFs, which - * don't necessarily have access to these details. - */ rc = efx_np_get_fixed_port_props(enp, epp->ep_np_handle, epp->ep_np_cap_data_raw, &epp->ep_phy_cap_mask, &epp->ep_np_loopback_cap_mask); -- 2.47.3
