> Subject: [PATCH v2 3/6] net/iavf: fix memory leak on error when adding flow > parser > > In iavf_register_flow_parser, the final "else" branch is an error leg
This should read "iavf_register_parser" instead of "iavf_register_flow_parser". Other than that Acked-by: Ciara Loftus <[email protected]> > which returns immediately, without adding the newly allocated > parser_node to a TAILQ. Add a free call for that parser_node in the > error case to avoid leaking memory. > > Fixes: ff2d0c345c3b ("net/iavf: support generic flow API") > Cc: [email protected] > > Signed-off-by: Bruce Richardson <[email protected]> > --- > drivers/net/intel/iavf/iavf_generic_flow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/intel/iavf/iavf_generic_flow.c > b/drivers/net/intel/iavf/iavf_generic_flow.c > index 84bb161bd1..92ca20031c 100644 > --- a/drivers/net/intel/iavf/iavf_generic_flow.c > +++ b/drivers/net/intel/iavf/iavf_generic_flow.c > @@ -1911,6 +1911,7 @@ iavf_register_parser(struct iavf_flow_parser > *parser, > list = &vf->dist_parser_list; > TAILQ_INSERT_HEAD(list, parser_node, node); > } else { > + rte_free(parser_node); > return -EINVAL; > } > > -- > 2.53.0
