On Wed, 24 Jun 2026 17:57:01 -0400
Dawid Wesierski <[email protected]> wrote:
> +
> +RTE_EXPORT_EXPERIMENTAL_SYMBOL(rte_pcapng_copy_ts, 26.07)
> +struct rte_mbuf *
> +rte_pcapng_copy_ts(uint16_t port_id, uint32_t queue,
> + const struct rte_mbuf *md,
> + struct rte_mempool *mp,
> + uint32_t length,
> + enum rte_pcapng_direction direction,
> + const char *comment,
> + uint64_t timestamp)
> {
I don't think you understood previous feedback.
- use API versioning to provide additional argument to rte_pcapng_copy
- do not introduce another function
The whole adjustment stuff just exists because the scaling parameters
are not available in rte_pcapng_copy() which is stateless and doesn't
want to have to lookup something in callback pdump_copy_burst.
Would like to have a more generic mechanism in future where timestamp
comes from hardware if available on rx. Then would need to have per-port
scaling conversion function.
