Optimize error handling in qman_query() to avoid redundant
checks and properly propagate error codes.

Fixes: 06268e2cb1 ("bus/dpaa: query queue frame count support")
Cc: [email protected]

Signed-off-by: Hemant Agrawal <[email protected]>
---
 drivers/bus/dpaa/base/qbman/qman.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/dpaa/base/qbman/qman.c 
b/drivers/bus/dpaa/base/qbman/qman.c
index 2da1b3e3f7..d289df2d33 100644
--- a/drivers/bus/dpaa/base/qbman/qman.c
+++ b/drivers/bus/dpaa/base/qbman/qman.c
@@ -1955,11 +1955,11 @@ int qman_query_fq(struct qman_fq *fq, struct qm_fqd 
*fqd)
                cpu_relax();
        DPAA_ASSERT((mcr->verb & QM_MCR_VERB_MASK) == QM_MCR_VERB_QUERYFQ);
        res = mcr->result;
-       if (res == QM_MCR_RESULT_OK)
-               *fqd = mcr->queryfq.fqd;
-       hw_fqd_to_cpu(fqd);
        if (res != QM_MCR_RESULT_OK)
                return -EIO;
+
+       *fqd = mcr->queryfq.fqd;
+       hw_fqd_to_cpu(fqd);
        return 0;
 }
 
-- 
2.43.0

Reply via email to