from pathlib import Path, PurePath
from typing import ClassVar, Final
+from api.capabilities import LinkTopology
from framework.config.test_run import (
DPDKBuildConfiguration,
DPDKBuildOptionsConfiguration,
@@ -263,7 +264,8 @@ def _build_dpdk(self) -> None:
ctx = get_ctx()
# If the SUT is an ice driver device, make sure to build with 16B
descriptors.
if (
- ctx.topology.sut_port_ingress
+ ctx.topology.type is not LinkTopology.NO_LINK
+ and not ctx.topology.sut_port_ingress
and ctx.topology.sut_port_ingress.config.os_driver == "ice"
):
I don't understand the change above. Surely we do want to set the custom meson
args for ICE DUTs when there is a sut_port_ingress, not when there isn't a
sut_port_ingress, right?
Also, does the topology type affect whether we want to use these custom args,
if the SUT driver is ice? I guess in a weird case we could have an ethdev test
using an ice DUT which does not need a TG?
Reviewed-by: Patrick Robb <[email protected]>
