From: Wei Hu <[email protected]> Add support for handling hardware service reset events in the MANA driver. When the MANA kernel driver receives a hardware service event, it initiates a device reset and notifies userspace via IBV_EVENT_DEVICE_FATAL. The MANA PMD handles this by performing an automatic teardown and recovery sequence.
The driver uses ethdev recovery events (ERR_RECOVERING, RECOVERY_SUCCESS, RECOVERY_FAILED) to notify upper layers of the reset lifecycle, and a PCI device removal event callback to distinguish hot-remove from service reset. Changes since v4: - Fixed stale rte_spinlock_unlock call in mana_intr_handler that was missed during the spinlock-to-mutex conversion, causing a -Wincompatible-pointer-types warning Changes since v3: - Converted reset_ops_lock from rte_spinlock_t to pthread_mutex_t with PTHREAD_PROCESS_SHARED, since the lock is held across blocking IB verbs calls and IPC with 5s timeout - Removed rte_dev_event_callback_unregister retry loop to avoid deadlock: the callback itself blocks on reset_ops_lock, so retrying on -EAGAIN while holding the lock is a deadlock - Introduced mana_join_reset_thread() helper using CAS on reset_thread_active to prevent double-join undefined behavior - Added reset thread join in mana_dev_uninit to prevent thread leak on device removal - Fixed ibv handle leak: priv->ib_ctx is now only set to NULL after ibv_close_device succeeds - Fixed misleading "All secondary threads are quiescent" log in mana_mp_reset_enter — changed to "Secondary doorbell pages unmapped" since actual quiescence is enforced by the primary's RCU QSBR check before IPC is sent - Changed event list in mana.rst to RST definition list style - Squashed documentation into the feature patch per convention Changes since v2: - Fixed dev_state_qsv memory leak on device removal - Fixed reset thread TCB/stack leak: reset_thread_active is now only cleared by the joiner, not the thread itself - Fixed second reset crash: removed reset thread join logic from mana_dev_close (inner function) to avoid corrupting dev_state when called from mana_reset_enter - Made reset_thread_active RTE_ATOMIC(bool) with explicit ordering - Added retry loop for rte_dev_event_callback_unregister on -EAGAIN - Initialized condvar/mutex with PTHREAD_PROCESS_SHARED since priv is in hugepage shared memory - Added re-check of dev_state after lock acquisition in mana_intr_handler to prevent racing with pci_remove_event_cb - Replaced (void *)0 with NULL in mp.c - Added lock ownership comment block at mana_reset_enter - Documented rte_dev_event_monitor_start() requirement - Added mana.rst documentation and release note Changes since v1: - Removed net/netvsc patch from this series - Simplified reset exit: mana_reset_exit calls mana_reset_exit_delay directly instead of spawning a thread - Added __rte_no_thread_safety_analysis annotations for clang - Switched to rte_thread_create_internal_control - Fixed declaration-after-statement style issues - Removed unnecessary blank lines and stale comments Wei Hu (1): net/mana: add device reset support doc/guides/nics/mana.rst | 38 + doc/guides/rel_notes/release_26_07.rst | 8 + drivers/net/mana/mana.c | 1005 ++++++++++++++++++++++-- drivers/net/mana/mana.h | 33 +- drivers/net/mana/meson.build | 2 +- drivers/net/mana/mp.c | 89 ++- drivers/net/mana/mr.c | 6 +- drivers/net/mana/rx.c | 24 +- drivers/net/mana/tx.c | 40 +- 9 files changed, 1138 insertions(+), 107 deletions(-) -- 2.34.1
